do not assume discriminator is not a property #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancetnik
requested changes
Sep 24, 2024
|
Btw, I am planning to make a release tomorrow evening. It will be great to see your fix in it. |
|
@Lancetnik I guess these 2 new tests should be enough, right? |
Lancetnik
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We happen to have property named
discriminatorin few of our models. This PR preventsKeyError: 'propertyName'since the schema generation code incorrectly assumesdiscriminatoris keyword used to specifypropertyName.Type of change
Please delete options that are not relevant.